chore: Fix tests #5320
Merged
chore: Fix tests #5320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have permissions to merge, not sure if this is by design for the main repo, just FYI. I'm OK merging these changes :) Merging is blocked |
|
I think VoxPelli was looking into getting you those permissions. In the meantime I can merge it 👍 |
|
@mark-wiemer @JoshuaKGoldberg I tried to improve it now |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses test failures on Node 20.19.0 by restricting the CI matrix to supported patch versions and adds a manual trigger for the workflow.
- Added
workflow_dispatchto allow manual runs of the test workflow. - Pinned the Node 20 version to 20.18.3 and Node 22 to 22.11.0 in the test matrix.
Comments suppressed due to low confidence (1)
.github/workflows/mocha.yml:71
- [nitpick] Consider using a semver range (e.g.,
'18, >=20.18.3 <20.19, 22.11.0') instead of a fixed patch version to avoid needing updates for each new patch release.
node-versions: '18,20.18.3,22.11.0'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
When moving to Node 20.19.0, we are seeing consistent test failures, and it's unclear why. For now, it's best to clarify that we only support Node 20.18.3 and continue investigation on issues with Node ^20.19.0 separately.
We will still have flaky issues with Windows 20.18.3 as clarified in #5052. I had to mark this PR as "fixing" the issue in order to pass a separate PR validation. I will reopen #5052 after this PR is merged for further investigation.