chore: Fixup Netlify config to deploy new site #5318
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ci(release-please): prereleases * fix!: adapt new version range Borrowing the version range of ESLint 9 * test: add engine range validation --------- Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* feat: bumped glob dependency from 8 to 10 * feat: bumped glob dependency from 8 to 10 * test: add --sort to --no-parallel tests * Switch from --sort in tests to preserving glob@8 sorting * Update glob sorting comment link * revert parallel.spec.js changes
* chore(main): release 11.1.0 * Manually switch to 11.0.1 * Manually switch to 11.0.1 * Manually switch to 11.0.1 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
Copied the new link from line 82.
* docs: replace "New in" with "Since" in version annotations * Change version annotations from "New in vX.Y.Z" to "Since vX.Y.Z" * Align with Node.js documentation style convention * Improve clarity for users upgrading from older versions Closes #5166 * Update docs/index.md Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com> * fix typo --------- Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
…5263) * Fix 5028 // Numerical arguments to cli throw uncaught error This PR throws a custom error which is (hopefully) easier to understand when: i. a numerical argument is passed to mocha cli ii. numerical value is used as a value for one of the mocha flags that is not compatible with numerical values. Signed-off-by: Dinika Saxena <dinika@greyllama.cc> * Use type-check to throw error instead of a broad try/catch Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com> * Rename numerical to numeric Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com> * Find flag for mocha cli after parsing yargs * Find flag for faulty numeric args before yargs parser Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com> * Add js-doc private keyword to fix netlify doc deployment * [Style] // Reduce code duplication * Add an "it" block for each flag for easier debug-ability Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com> * Remove ? from flag since it cannot be undefined * Add test cases for empty string checks for isNumeric * Do not add extra leading -- in error message for flag * Throw error for numeric positional arg after yargs-parser has parsed args Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com> * Revert timeout and slow as string flags so that they can accept human readable values Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com> --------- Signed-off-by: Dinika Saxena <dinika@greyllama.cc> Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com>
When node is run with [--frozen-intrinsics], a `TypeError` is thrown when any intrinsic objects or their properties are modified. This occurs when attempting to set `Error.stackTraceLimit`. To avoid exiting due to an uncaught exception, catch the exception, debug log it, and continue. [--frozen-intrinsics]: https://nodejs.org/api/cli.html#--frozen-intrinsics Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* feat: bump yargs to 17 * fix: prefer coerced reporter-option for options * Aha, fix: process.exit() instead of process.exitCode * fix: --list-interfaces one-and-done conflict
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* chore: pin node-lts tests to 22.11.0 * Also update other 22s
* Replace fs-extra with newer fs built-ins This updates the codebase to remove two uses of fs-extra by newer fs built-in functions. The code changes are based on the implementation of fs-extra@10.1.0, which is the version of fs-extra recorded in the project's lockfile. In particular, for `watch.spec.js`, the changes are based on: https://github.com/jprichardson/node-fs-extra/blob/0220eac966d7d6b9a595d69b1242ab8a397fba7f/lib/remove/index.js#L15 and, also for `helper.js`, the changes are based on: https://github.com/jprichardson/node-fs-extra/blob/0220eac966d7d6b9a595d69b1242ab8a397fba7f/lib/mkdirs/make-dir.js#L23 * Drop 14 and 16 in mocha.yml --------- Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
* Improve hosted docs for `runnable` * Document usages of `Runner.constants` * Update lib/runnable.js Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com> * Update lib/runnable.js --------- Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
* chore: enabled eslint-plugin-n * Actually included rules, without the override * Revert unrelated formatting changes * fix test/node-unit/cli/options.spec.js tests * Use @rollup/plugin-alias for building node: prefixes
* docs: add new website using Astro Starlight * chore: add docs command to package.json * Add supporters.js dependencies * add root-level install to npm run docs * remove question mark * docs-next/netlify.toml * console.log(process.env) * Don't have /next base in Netlify * More proper astro.config.mjs * linting * Smaller title * Dark mode fixups * Slightly darker sl-color-white * Mentioned this being WIP * Missing _ * Tweaked notice * Tweaked notice colors * Tweaked notice text * fix /api and /example/tests.html links * fix: responsive homepage title * fix: sized responsive homepage title * Added <Head> override for mocha-thumbnail.svg * Added starting buttons * fix: starting buttons config link * fix: starting buttons 'ing' * Footer mobile responsiveness, and root netlify.toml revert * Simpler, more accurate test file * chore: rm docs-next/pnpm-lock.yaml * chore: docs-next should not have pnpm at all * docs: generate, not prebuild * Apply suggestions from code review Co-authored-by: Mark Wiemer <7833360+mark-wiemer@users.noreply.github.com> * First round of feedback updates * Missed a sidebar heading title * Update docs-next/src/content/docs/index.mdx Co-authored-by: Mark Wiemer <7833360+mark-wiemer@users.noreply.github.com> --------- Co-authored-by: Mark Wiemer <7833360+mark-wiemer@users.noreply.github.com>
* DRAFT // Get test file path relative to config Signed-off-by: Dinika Saxena <dinika@greyllama.cc> * Use cwd for finding relative path of test fil * Use relative path options in json and json-stream reporters * Add integration test for relative paths in xunit reporter Signed-off-by: Dinika Saxena <dinika@greyllama.cc> * Make test more complete by checking for non existence * Keep showing absolute paths in json reporters * Add doc for showRelativePath xunit reporter option Signed-off-by: Dinika Saxena <dinika@greyllama.cc> * Move relative path calculation to the only reporter (xunit) that needs it * Fix typo in xunit doc for showRelativePaths option Signed-off-by: Dinika Saxena <dinika@greyllama.cc> * Clarify why testing for absence of relative paths need quotes * Copied new docs .md contents to docs-next .mdx --------- Signed-off-by: Dinika Saxena <dinika@greyllama.cc> Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Fix typos, improve readability * Cleanup decision tree intro
✅ Deploy Preview for mocha-docs-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
It's working! |
3 tasks
|
Closing as this was a test PR to trigger a netlify build with new code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
"Force" Netlify to use
npminstead ofpnpmto get around our weird build issues.Note this issue is only visible in Netlify so non-trusted contributors won't be able to see a lot of the context here.