Skip to content

fix: support errors with circular dependencies in object values with --parallel #5212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 29, 2024
Merged

fix: support errors with circular dependencies in object values with --parallel #5212

merged 3 commits into from
Oct 29, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Sep 12, 2024 •
edited
Loading

PR Checklist

Overview

Only calling breakCircularDeps on result.error means any circular references in other properties of result still go through. SerializableEvent._serialize can generally visit them fine, but they still end up being infinitely added to pairs. This PR adds a seenPairs Set to make sure they only get serialized once each. This fixes #5209.

Also only writes to properties with .writable object descriptors. This fixes #5188.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft September 12, 2024 11:25
@JoshuaKGoldberg
Copy link
Member Author

The test failures on Node 22 happen for me locally on main too. Filed #5213.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review September 12, 2024 12:22
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Oct 8, 2024
Closed
4 tasks
JoshuaKGoldberg
JoshuaKGoldberg commented Oct 29, 2024
View reviewed changes
Copy link
Member Author

@JoshuaKGoldberg JoshuaKGoldberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the other maintainers haven't had time to review this & aren't consistently active this month, I'm just going to go ahead and merge it myself.

@JoshuaKGoldberg JoshuaKGoldberg merged commit ba0fefe into mochajs:main Oct 29, 2024
105 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the fix-circular-object-deps branch October 29, 2024 20:38
@github-actions github-actions bot mentioned this pull request Oct 29, 2024
Merged
@averissimo averissimo mentioned this pull request Nov 5, 2024
Open
@kevinoid kevinoid mentioned this pull request Nov 14, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voxpelli voxpelli Awaiting requested review from voxpelli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@JoshuaKGoldberg