Skip to content

feat: allow ^ versions for character encoding packages #5150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 2, 2024
Merged

feat: allow ^ versions for character encoding packages #5150

merged 5 commits into from
Jul 2, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented May 30, 2024 •
edited
Loading

PR Checklist

Overview

Adds a ^ range to the following packages related to character encoding in logs:

  • ansi-colors: new minor versions available, up to 4.1.3 - which it's upgraded to now
  • browser-stdout: latest version; hasn't been updated in 6 years
  • escape-string-regexp: no new minor versions available - just a new major
  • he: latest version; hasn't been updated in 6 years
  • log-symbols: no new minor versions available - just new majors
  • supports-color: no new minor versions available - just a new major

@JoshuaKGoldberg JoshuaKGoldberg force-pushed the minor-versions-character-encoding-packages branch from 8d8af57 to 352b483 Compare May 30, 2024 21:02
@coveralls
Copy link

coveralls commented May 30, 2024 •
edited
Loading

Coverage Status

coverage: 94.359% (+0.001%) from 94.358%
when pulling 5d9818f on JoshuaKGoldberg:minor-versions-character-encoding-packages
into 472a8be on mochajs:master.

@JoshuaKGoldberg JoshuaKGoldberg force-pushed the minor-versions-character-encoding-packages branch from 352b483 to 993c3a6 Compare May 30, 2024 21:06
@JoshuaKGoldberg JoshuaKGoldberg force-pushed the minor-versions-character-encoding-packages branch from 993c3a6 to 00a7f9f Compare May 30, 2024 21:09
@JoshuaKGoldberg JoshuaKGoldberg added the semver-minor implementation requires increase of "minor" version number; "features" label May 30, 2024
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team May 30, 2024 21:13
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request May 31, 2024
Closed
voxpelli
voxpelli requested changes May 31, 2024
View reviewed changes
Copy link
Member

@voxpelli voxpelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one change looks indeed harmless: doowb/ansi-colors@4.1.1...4.1.3

But can you do a new npm install ansi-colors@^4.1.3 to ensure that our lockfile actually also references it?

JoshuaKGoldberg
JoshuaKGoldberg commented May 31, 2024
View reviewed changes
voxpelli
voxpelli reviewed Jun 4, 2024
View reviewed changes
@JoshuaKGoldberg JoshuaKGoldberg requested a review from voxpelli June 22, 2024 23:11
@JoshuaKGoldberg JoshuaKGoldberg merged commit 38695da into mochajs:main Jul 2, 2024
@JoshuaKGoldberg JoshuaKGoldberg deleted the minor-versions-character-encoding-packages branch July 2, 2024 15:46
@JoshuaKGoldberg
Copy link
Member Author

Released in mocha@v10.6.0. 🚀

@tylerezimmerman tylerezimmerman mentioned this pull request Jul 25, 2024
Merged
@saileshvyas saileshvyas mentioned this pull request Jul 27, 2024
Open
This was referenced Jul 28, 2024
Closed
Merged
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 28, 2024
Merged
@hashim21223445 hashim21223445 mentioned this pull request Jul 29, 2024
Merged
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 29, 2024
Merged
@hashim21223445 hashim21223445 mentioned this pull request Aug 7, 2024
Merged
@dlminvestments dlminvestments mentioned this pull request Aug 10, 2024
Open
@abdulrahman305 abdulrahman305 mentioned this pull request Aug 10, 2024
Merged
@hashim21223445 hashim21223445 mentioned this pull request Aug 11, 2024
Merged
@hashim21223445 hashim21223445 mentioned this pull request Aug 11, 2024
Merged
This was referenced Aug 11, 2024
Closed
Closed
@malforsaja malforsaja mentioned this pull request Aug 11, 2024
Merged
@hoang3402 hoang3402 mentioned this pull request Aug 11, 2024
Closed
@erossignon erossignon mentioned this pull request Aug 11, 2024
Closed
@hashim21223445 hashim21223445 mentioned this pull request Aug 12, 2024
Merged
@hoang3402 hoang3402 mentioned this pull request Aug 12, 2024
Closed
@abdulrahman305 abdulrahman305 mentioned this pull request Aug 13, 2024
Closed
This was referenced Aug 13, 2024
Merged
Merged
@hoang3402 hoang3402 mentioned this pull request Aug 13, 2024
Merged
@MaxMood96 MaxMood96 mentioned this pull request Aug 25, 2024
Closed
@SapiannykSerhii SapiannykSerhii mentioned this pull request Sep 25, 2024
Open
@guram21 guram21 mentioned this pull request Oct 4, 2024
Merged
@MaxMood96 MaxMood96 mentioned this pull request Oct 6, 2024
Closed
@sminnee sminnee mentioned this pull request Oct 19, 2024
Merged
This was referenced Oct 23, 2024
Open
Open
@rona-dinihari rona-dinihari mentioned this pull request Oct 24, 2024
Closed
@abdulrahman305 abdulrahman305 mentioned this pull request Oct 27, 2024
Closed
@HaLaGu1L HaLaGu1L mentioned this pull request Nov 1, 2024
Open
@SkyeFull90 SkyeFull90 mentioned this pull request Nov 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voxpelli voxpelli Awaiting requested review from voxpelli

Assignees
No one assigned
Labels
semver-minor implementation requires increase of "minor" version number; "features"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📦 Package: Switch dependency versions to ^ ranges
3 participants
@JoshuaKGoldberg @coveralls @voxpelli