-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Closed
Labels
status: accepting prsMocha can use your help with this one!Mocha can use your help with this one!type: featureenhancement proposalenhancement proposal
Description
Feature Request Checklist
- I have read and agree to Mocha's Code of Conduct and Contributing Guidelines
- I have searched for related issues and issues with the
faq
label, but none matched my issue. - I want to provide a PR to resolve this
Overview
Mocha currently depends an older major version of diff
:
Line 100 in 5cf2b09
"diff": "^5.2.0", |
Suggested Solution
diff@7.0.0
is the latest. It'd be nice to bump to that, so users aren't stuck on a dep that's two major versions behind.
Alternatives
This isn't critical and I don't think we need to do it. But it's nice ecosystem cleanup in general.
I don't know of popular alternatives to diff
and haven't looked for them.
Additional Info
The diff
package is used in example one place internally, the Base
reporter class:
Line 9 in a2e600d
var diff = require('diff'); |
Line 511 in a2e600d
var msg = diff.createPatch('string', actual, expected); |
Lines 532 to 534 in a2e600d
return diff | |
.diffWordsWithSpace(actual, expected) | |
.map(function (str) { |
diff@7
still supports older Node.js versions than Mocha, so I don't believe we're blocked on that.
Metadata
Metadata
Assignees
Labels
status: accepting prsMocha can use your help with this one!Mocha can use your help with this one!type: featureenhancement proposalenhancement proposal