-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Closed
Labels
status: accepting prsMocha can use your help with this one!Mocha can use your help with this one!type: choregenerally involving deps, tooling, configuration, etc.generally involving deps, tooling, configuration, etc.
Description
Similar to #2800, while the test suite can be run on Windows (e.g. using MinGW make with either Cygwin or Git Shell), certain tests fail if certain files do not have the right line endings:
test/acceptance/glob/glob.sh
-- this just needs to be Linux line endings, should probably be converted to them by the test run if possible regardless of how they may have been changed- something in
test/integration/fixtures/diff
-- perhaps just theoutput
file? and not sure if the right line endings here are always Linux, or depend on the OS, or depend on whether the tests are being run from a Posixy environment (as is necessary to use the Makefile)
More meta-like, if this ends up requiring per-file fiddling, then it would be really, really helpful to have some way of guaranteeing that our CI runs won't succeed just because they happen to have the right global settings that developers may or may not have. It doesn't make sense to have something that we need to set up correctly for certain tests that won't fail CI if we get it wrong.
Metadata
Metadata
Assignees
Labels
status: accepting prsMocha can use your help with this one!Mocha can use your help with this one!type: choregenerally involving deps, tooling, configuration, etc.generally involving deps, tooling, configuration, etc.