handle delete when message id bytes #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mlasevich ☝️ 😃 |
|
My apologies, will take a look |
mlasevich
approved these changes
Apr 16, 2025
| if int(result[0]) == 1 and int(result[1]) > 0: | ||
| # 1 key deleted from zset | ||
| # 3 keys deleted from hash (message itself, receive count, first receive field) | ||
| if int(result[0]) == 1 and int(result[1]) == 3: |
There was a problem hiding this comment.
Is there a scenario where result[1] > 0 but not 3?
There was a problem hiding this comment.
I don't think so, unless the number of keys stored per message in the hash changes. From what I could tell, the message, receive count, and first receive are always there, so if there are not deleted then there would be some sort of problem. That was my thought process around this.
There was a problem hiding this comment.
makes sense.... BTW, it is out as v0.6.1 🤞🏻
|
|
||
| # decode to string when provided as bytes | ||
| if isinstance(message_id, bytes): | ||
| message_id = message_id.decode('utf-8') |
There was a problem hiding this comment.
to avoid issues with tx.zrem() we may want to adjust the message id specifically for generated rc/fr keys - but it seems to work fine as-is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decode message_id to
strwhen it is provided asbytes.Closes #17