Fix document symbol links #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And I tried to run |
davidkoski
reviewed
Apr 10, 2025
| @@ -1,4 +1,4 @@ | |||
| // swift-tools-version: 5.9 | |||
| // swift-tools-version: 5.10 | |||
There was a problem hiding this comment.
My only concern is this bump -- it moves the requirement forward from 2023 -> 2024 for Xcode & swift versions.
I don't think we ave a good way to judge what people are using, so perhaps we just take this and can consider reverting if it causes trouble.
davidkoski
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug around swift-docc that could not generate symbol links for
--=//=.And this was fixed in Swift 5.10 based on swiftlang/swift-docc#808. So this PR adds symbol links for these operators.