rename update -> _updateInternal to discourage callers #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkoski
commented
Apr 30, 2025
| @@ -61,12 +61,6 @@ extension MLXArray { | |||
| } | |||
| } | |||
|
|
|||
| /// Replace the interior ctx (`mlx_array` pointer) with a new value by transferring ownership | |||
| @inline(__always) | |||
| func update(_ ctx: mlx_array) { | |||
There was a problem hiding this comment.
This was internal to the indexing code and takes a bare mlx_array. Only a single callers so I just moved the body there (it is already calling mlx-c code so this is IMHO less confusing)
davidkoski
commented
Apr 30, 2025
| /// | ||
| /// Note: this is an implementation detail and only visible because of the need to call it from | ||
| /// other `mlx-swift` modules. | ||
| public func _updateInternal(_ array: MLXArray) { |
There was a problem hiding this comment.
Rename and updated docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.