Skip to content

Conversation

davidkoski
Copy link
Collaborator

Per report of padded() not linking in the docs.

@davidkoski davidkoski requested review from awni and barronalex April 9, 2025 19:24
@@ -1,11 +1,11 @@
# Compilation

MLX has a ``compile(inputs:outputs:shapeless:_:)-7korq`` function transformation which compiles computation
MLX has a ``compile(inputs:outputs:shapeless:_:)-8wq3u`` function transformation which compiles computation
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These hashes are generated by Xcode and sometimes ... they change? I saw a mention of a new disambiguation scheme but it will require a newer toolchain.

- ``padded(_:width:value:stream:)``
- ``padded(_:widths:value:stream:)``
- ``padded(_:width:mode:value:stream:)``
- ``padded(_:widths:mode:value:stream:)``
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the reported issue -- we have a new optional parameter and the docs didn't reflect it.

Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@davidkoski davidkoski merged commit 98b48a7 into main Apr 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants