Skip to content

Fix https://github.com/ml-explore/mlx-swift-examples/issues/218 #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2025
Merged

Fix https://github.com/ml-explore/mlx-swift-examples/issues/218 #200

merged 1 commit into from
Mar 10, 2025

Conversation

davidkoski
Copy link
Collaborator

  • do not fail parameter update validation for "invalid" keys (e.g. _freqs)

In particular SuScaledRotaryEmbedding is failing validation on update(parameters:) because of a missing _freqs:

public class SuScaledRotaryEmbedding: Module {
    let _freqs: MLXArray

    public init(
...
    ) {
...
        let exponent =
            MLXArray(stride(from: 0, to: dimensions, by: 2)).asType(.float32) / Float(dimensions)
        let freqs = MLX.pow(MLXArray(base), exponent)
        self._freqs = MLXArray(longFactor).asType(.float32) * freqs

_freqs isn't really a parameter -- it is not meant to be updated, hence the naming with _.

@davidkoski
Fix ml-explore/mlx-swift-examples#218
d93271b 
- do not fail parameter update validation for "invalid" keys (e.g. _freqs)
@davidkoski davidkoski requested a review from awni March 7, 2025 23:12
@davidkoski davidkoski mentioned this pull request Mar 7, 2025
Closed
awni
awni approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!!

@davidkoski davidkoski merged commit 118e448 into ml-explore:main Mar 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awni awni awni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidkoski @awni