Skip to content

Remove package.resolved #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

louen
Copy link
Contributor

@louen louen commented Feb 13, 2025

This PR removes the Package.Resolved file which is automatically generated / updated by Xcode or swift build when loading a swift package. The file is also added to the .gitignore, alongside other standard swift package manager ignores.

See Should Package.Resolved go in the git ignore for a discussion of the ins and out of tracking this specific file, but in summary :

Pros :

  • this prevents spurious warnings about updates in that file which can happen normally as part of the dependency resolution.

Cons:

  • this unpins the exact value of the dependency (swift-numerics in this case), leaving it up to the specification of Package.swift

Copy link
Collaborator

@davidkoski davidkoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@davidkoski davidkoski merged commit de17252 into ml-explore:main Feb 13, 2025
3 checks passed
@louen louen deleted the val/remove_package_resolved branch February 13, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants