Skip to content

Add setErrorHandler and fatalErrorHandler #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 1, 2025
Merged

Add setErrorHandler and fatalErrorHandler #179

merged 1 commit into from
Jan 1, 2025

Conversation

finnvoor
Copy link
Contributor

  • exposes setErrorHandler from mlx-c
  • Adds a fatalErrorHandler which calls fatalError, recording a stack trace and attaching the debugger in Xcode. It would be nice to set this by default in mlx-swift, but I'm not sure if that's possible.

Usage: setErrorHandler(fatalErrorHandler)

@davidkoski
Copy link
Collaborator

Looks nice! Please apply swift-format as per:

Thanks

davidkoski
davidkoski approved these changes Jan 1, 2025
View reviewed changes
Copy link
Collaborator

@davidkoski davidkoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution!

@davidkoski davidkoski merged commit 7ea1257 into ml-explore:main Jan 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkoski davidkoski davidkoski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@finnvoor @davidkoski