Skip to content

remove gguf -- fix #111 #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 17, 2024
Merged

remove gguf -- fix #111 #176

merged 2 commits into from
Dec 17, 2024

Conversation

davidkoski
Copy link
Collaborator

  • this removes gguf from the build
  • was being built but not linked/used

@davidkoski
remove gguf -- fix ml-explore#111
f8957f6 
- this removes gguf from the build
- was being built but not linked/used
@davidkoski davidkoski requested a review from awni December 17, 2024 00:59
awni
awni approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@davidkoski
Copy link
Collaborator Author

I need to figure out why circleci won't build it -- it builds ok locally.

@davidkoski davidkoski merged commit 6ffbf85 into ml-explore:main Dec 17, 2024
3 checks passed
@davidkoski
Copy link
Collaborator Author

just a stale symlink. curious that my local build was fine with it, and in fact the build here said it was being ignored. :-)

@davidkoski davidkoski deleted the no-gguf branch December 17, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awni awni awni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidkoski @awni