Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
m.update(parameters: ..., verify: .all)
on a module, there is no check that is performed to ensure that all the parameters underm
have been set. This has bitten me a couple times when porting a model to mlx-swift, and I think it's related to this todo in Module.swift.This PR adds some support to check also for this. A couple comments:
.apply
where the.value
can be.none
for the case where we don't have anything in the parameters but have to go through the modules to check that there is no parameter to be set..dictionary
case , the iteration has been changed so that we ensure to go over all the model items rather than going through all the parameters..all
not to include the new.allModelKeysSet
and have a new.strict
flag that is.all + .allModelKeysSet
.Any feedback on this is very welcome.