Skip to content

Update attention tests #1978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2025
Merged

Update attention tests #1978

merged 1 commit into from
Mar 20, 2025

Conversation

jagrit06
Copy link
Member

Proposed changes

  • Update attention tests to show diff
  • Disable array masks

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING document
  • I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation (if needed)

awni
awni approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jagrit06 jagrit06 merged commit b42d13e into main Mar 20, 2025
5 checks passed
@jagrit06 jagrit06 deleted the attn-test-fix branch March 20, 2025 21:25
rykyer
rykyer reviewed Apr 2, 2025
View reviewed changes
Copy link

@rykyer rykyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よき

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awni awni awni approved these changes

+1 more reviewer

@rykyer rykyer rykyer left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jagrit06 @awni @rykyer