Skip to content

Add boolean mask support in vector SDPA #1757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2025
Merged

Add boolean mask support in vector SDPA #1757

merged 1 commit into from
Jan 8, 2025

Conversation

awni
Copy link
Member

@awni awni commented Jan 8, 2025

Add optional boolean mask in vector SDPA metal kernel:

Timing sdpa ... 3.01268 msec
Timing attention ... 7.13981 msec
Timing attention_mask ... 7.50264 msec
Timing sdpa_mask ... 2.24858 msec

Using the mask + sdpa is a lot faster than the naive primitive with a mask.

@awni awni requested review from angeloskath and barronalex January 8, 2025 01:15
barronalex
barronalex approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@barronalex barronalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s an awesome speed up!!
Super clean with the function constant too 🚀

mlx/backend/metal/kernels/sdpa_vector.h
score = simd_sum(score);
// Compute the i-th score
U score = 0;
for (int j = 0; j < elem_per_thread; j++) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for removing the shadowing on i here

@awni awni force-pushed the bool_mask_vector_sdpa branch from 970314a to 7ae5624 Compare January 8, 2025 03:50
@awni awni merged commit d1766f2 into main Jan 8, 2025
5 checks passed
@awni awni deleted the bool_mask_vector_sdpa branch January 8, 2025 04:24
@BrewTestBot BrewTestBot mentioned this pull request Jan 9, 2025
Merged
1 task
@EricLBuehler EricLBuehler mentioned this pull request Jan 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angeloskath angeloskath Awaiting requested review from angeloskath

1 more reviewer

@barronalex barronalex barronalex approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@awni @barronalex