Skip to content

CMake: Build with dlfcn-win32 to have dlopen etc. on win32 #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

stemann
Copy link
Contributor

@stemann stemann commented Nov 26, 2024

Proposed changes

CMake: Build with dlfcn-win32 to have dlopen etc. on win32

Cf. JuliaPackaging/Yggdrasil#9761

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING document
  • I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation (if needed)

Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me! Will merge when tests clear.

@awni awni merged commit 698e63a into ml-explore:main Nov 27, 2024
6 checks passed
@stemann stemann deleted the feature/cmake_w64-mingw32 branch November 28, 2024 10:16
stemann added a commit to stemann/mlx-c that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants