Skip to content

Convert filesystem path to std::string explicitly #1672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2024
Merged

Convert filesystem path to std::string explicitly #1672

merged 1 commit into from
Dec 8, 2024

Conversation

zcbenz
Copy link
Collaborator

@zcbenz zcbenz commented Dec 8, 2024

Refs #1513.

The std::filesystem::path can not be silently converted to std::string on Windows because the native path uses a different char type.

awni
awni approved these changes Dec 8, 2024
View reviewed changes
Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

awni
awni approved these changes Dec 8, 2024
View reviewed changes
Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@awni awni merged commit 7c10c93 into ml-explore:main Dec 8, 2024
5 checks passed
@zcbenz zcbenz deleted the msvc-fs-str branch January 29, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awni awni awni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zcbenz @awni