Skip to content

Conversation

zcbenz
Copy link
Collaborator

@zcbenz zcbenz commented Dec 7, 2024

Refs #1513.

MSVC can not deduce auto to be a pointer and would complain delete p not working.

Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that might be incorrect in the spec, but it deduced it correctly somehow with clang.

@awni awni merged commit 96986fb into ml-explore:main Dec 8, 2024
5 checks passed
@zcbenz zcbenz deleted the msvc-auto-ptr branch January 29, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants