Skip to content

Allow scatter type exception to be caught by checking in op #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 14, 2024
Merged

Allow scatter type exception to be caught by checking in op #1077

merged 3 commits into from
May 14, 2024

Conversation

awni
Copy link
Member

@awni awni commented May 5, 2024

Closes #1076

@awni awni mentioned this pull request May 5, 2024
Closed
angeloskath
angeloskath approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@angeloskath angeloskath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@awni awni force-pushed the scatter_exception branch from 151027d to 2ad0754 Compare May 14, 2024 00:35
@awni awni merged commit 863039d into main May 14, 2024
@awni awni deleted the scatter_exception branch May 14, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angeloskath angeloskath angeloskath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] mlx crashes with msg - uncaught exception of type std::invalid_argument: [Scatter::eval_gpu] Does not support int64
2 participants
@awni @angeloskath