Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1066
This is kind of a nanobind issue but one that they have refused to fix in the past.
np.ndarray
is implicitly convertible to astd::complex<float>
so ourto_array
was allowing that.np.ndarrays
instead I added it as a member in the variant.mx.array
gets implicitly converted tonb::ndarray
because of the buffer protocol.array
as a member of the variant.