Add fuzzing, fix things that were discovered #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeeter
added a commit
that referenced
this pull request
Jan 19, 2025
Fixes #11, with three bugs discovered by fuzzing: - `_NIP2r` was incorrect in assembly, with two digits swapped - `_SWP2r` was incorrect in assembly, with a single digit mistake - `sft` was incorrect in the interpreter implementation, because wrapping_shl/shr doesn't return zeros if you shift out of range
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11, with three bugs discovered by fuzzing:
_NIP2rwas incorrect in assembly, with two digits swapped_SWP2rwas incorrect in assembly, with a single digit mistakesftwas incorrect in the interpreter implementation, becausewrapping_shl/shrdoesn't return zeros if you shift out of range