Infer titles of pages based on full Markdown parsing #3191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly parse Markdown and report the first H1 tag rather than naively looking for `# Stuff` at the start of the doc. This satisfies feature requests such as supporting setext-style headers and fixes attr-list suffixes that failed to be ignored.
Co-authored-by: Hendrik Polczynski <hendrikpolczyn@gmail.com>
Co-authored-by: Darrick Herwehe <darrick@exitcodeone.com>
This was referenced Apr 21, 2023
|
I believe that I found a small bug in the logic of extracting the title. The loop always breaks after looking at the first element instead of after |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly parse Markdown and report the first H1 tag rather than naively looking for
# Stuffat the start of the doc.This satisfies feature requests such as supporting setext-style headers and fixes attr-list suffixes that failed to be ignored.