-
-
Notifications
You must be signed in to change notification settings - Fork 115
feat: i18n support #645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: i18n support #645
Conversation
Sorry for the very long wait @BlueGlassBlock 🙇 I've updated the PR to use I also changed the logic so that the computed locale is passed to the handlers' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK LGTM now! Next update in the Python handler will allow using this new locale
parameter 😄
Last year I opened mkdocstrings/python#77 to add initial i18n infrastructure, yet I forgot to propose changes on mkdocstrings side & add documentation until I recently picked up Python again.
This PR, combined with mkdocstrings/python#TODO should make internationalization fully prepared and exposed.