Fix BiMap.put/3 mapping update issue #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaput
reviewed
Jun 17, 2019
| check all key_set <- nonempty(uniq_list_of(term())), | ||
| value_set <- uniq_list_of(term(), length: Enum.count(key_set)), | ||
| check all key_set <- nonempty(uniq_list_of(atom(:alphanumeric))), | ||
| value_set <- uniq_list_of(integer(), length: Enum.count(key_set)), |
There was a problem hiding this comment.
Actually, there is a deeper problem with this test:
iex> regular_map = %{x: 0}
iex> bimap = BiMap.new(regular_map)
iex> Map.put(regular_map, :a, 0)
#BiMap<[x: 0]>
iex> BiMap.put(bimap, :a, 0)
#BiMap<[a: 0]>I'll push proper fix directly onto master
|
Welp, good catch! Thanks! |
|
@NullOranje I have just pushed a new version |
|
Neat. Glad I could help make a nice module a little bit better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrote a patch to resolve the issue identified in #4. It simply removes any existing reverse-mappings prior to updating the BiMap. Added a test to ensure that
BiMap.put/3updates correctly.Because of failures with the random StreamData, I modified the
it puts items into bimapstest to use a single type when generating the initial map. Keys are now always atoms, and values are always integers.