Skip to content

Conversation

eikaramba
Copy link
Contributor

This is a "problem" we had when saving a screenshot for a file, which e.g. has relative path to images in the current working folder /root/emailA/... while the project folder is /root. Then the images are not displayed as the temporary file is sitting in some temporary folder of the OS. I changed it so that the temporary file is saved in the working folder. After taking all screenshots the file is deleted.

Of course one should never deploy a html file with relative folder, however during testing the marketing team might want to send some screenshots and in this case having the relative paths for images etc. is crucial.

Idea for another ticket: Having the HTML export actually warn via a dialog or so if relative paths were detected in the export ;)

@meriadec meriadec merged commit 853b9c8 into mjmlio:master May 13, 2018
@meriadec
Copy link
Contributor

Makes sense. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants