Skip to content

Roman numerals #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 10, 2025
Merged

Roman numerals #46

merged 5 commits into from
Apr 10, 2025

Conversation

GregT2207
Copy link
Contributor

This resolves issue #44 and relates to issue #35

  • Roman numerals for all 9 episodes have been added
  • They get mapped to floats when building the AST
  • Math test expanded to include them
  • Example file added to use them

If we want full Roman numeral support then let me know, I'd be happy to expand on this!
For now I thought this would be a good start.

mirdaki
mirdaki approved these changes Apr 10, 2025
View reviewed changes
Copy link
Owner

@mirdaki mirdaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh fantastic! Agree, this is a great place to start. Having full roman numeral support would be a fun addition, but this is the core of it. Thanks for including an example file as well!

@mirdaki mirdaki merged commit 60028ac into mirdaki:main Apr 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirdaki mirdaki mirdaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GregT2207 @mirdaki