Allow up to 100 CI checks for CI status command #2704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI seems to be failing to on the |
I'm working on a project that has a complex CI setup, and reaches more than 30. Sometimes `hub ci-status` would report success when it was still pending, which was very annoying. per_page=100 is used in many other queries, and is the maximum that is allowed without paging.
f106450 to
63bdaa5
Compare
|
I've rebased and force pushed now that CI is working again. |
av1934413
reviewed
Nov 21, 2022
| @@ -565,7 +565,7 @@ func (client *Client) FetchCIStatus(project *Project, sha string) (status *CISta | |||
| } | |||
| sortStatuses() | |||
|
|
|||
| res, err = api.GetFile(fmt.Sprintf("repos/%s/%s/commits/%s/check-runs", project.Owner, project.Name, sha), checksType) | |||
| res, err = api.GetFile(fmt.Sprintf("repos/%s/%s/commits/%s/check-runs?per_page=100", project.Owner, project.Name, sha), checksType) | |||
| if err == nil && (res.StatusCode == 403 || res.StatusCode == 404 || res.StatusCode == 422) { | |||
| return | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on a project that has a complex CI setup, and uses more than 30 CI jobs. Sometimes
hub ci-statuswould report success when it was still pending, which was very annoying, because it was only checking the first 30.per_page=100is used in many other queries, and is the maximum that is allowed without paging.