Skip to content

Conversation

MonaAghili
Copy link
Member

based on #41 #131 #88

Close: #362

@tanguilp
Copy link

LGTM 😎 (but who cares)

@shahryarjb
Copy link
Member

@tanguilp Hi. Maybe I didn’t understand that part because my English isn’t very strong 🥴, especially when you said "but who cares."

@tanguilp
Copy link

Kind of a joke. I meant it's not up to me to make the decision to merge this PR :)

Again, keep up the great work. I especially enjoyed using the RadioCard element. See for yourself:

image

@shahryarjb
Copy link
Member

@tanguilp
Thank you so much for all the effort you've put into the project report and testing. It really helps us improve the stability of this version. I truly appreciate it.

Please don’t hesitate to send us any issues you come across — we’ll make sure to address them as soon as possible.

We have several pull requests related to stability lined up for this Friday, and we’ll merge them then. We’ll also quickly take care of the other pending items alongside them.

Apologies for the delay in processing pull requests — the reason is that the components are quite large, and we’re just a two-person team. We have to test each component individually across two platforms: the Mishka website and the community version, and only then can we apply them to this project.

Thank you in advance

@shahryarjb shahryarjb merged commit fdb60f0 into mishka-group:master Apr 25, 2025
@MonaAghili MonaAghili deleted the tabs-accessability-classes branch April 25, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab active slot not showing
3 participants