Skip to content

Feat: Add gradient and borderd variants of popover #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 19, 2024
Merged

Feat: Add gradient and borderd variants of popover #121

merged 4 commits into from
Nov 19, 2024

Conversation

MonaAghili
Copy link
Member

@MonaAghili MonaAghili commented Nov 19, 2024 •
edited by shahryarjb
Loading

Summary:

  • Add variant gradient and bordered
  • Modify colors add support of dark mode
  • Add a new prop show_arrow to help user control showing of arrow of popover

Example usage of show_arrow

If you do not set this property, it will be set to true and the arrow will appear

<.popover>
   <.popover_trigger></.popover_trigger>
   <.popover_content show_arrow={false}></.popover_content>
</.popover>

<.popover>
   <.popover_trigger></.popover_trigger>
   <.popover_content show_arrow={true}></.popover_content>
</.popover>

Close #116

@MonaAghili MonaAghili self-assigned this Nov 19, 2024
@shahryarjb shahryarjb added this to the 0.0.2 milestone Nov 19, 2024
@shahryarjb shahryarjb changed the title Feat: Add gradient and borderd variants Feat: Add gradient and borderd variants of popover Nov 19, 2024
@shahryarjb shahryarjb merged commit 712c444 into mishka-group:master Nov 19, 2024
@MonaAghili MonaAghili deleted the 0.0.2-popover-colors branch November 19, 2024 12:42
@shahryarjb shahryarjb mentioned this pull request Nov 22, 2024
Closed
81 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahryarjb shahryarjb shahryarjb approved these changes

Assignees

@MonaAghili MonaAghili

Labels
Kind: Refactor Level:CoreTeam
Projects
None yet
Milestone
0.0.2
Development

Successfully merging this pull request may close these issues.

Suggestion: Popover arrow color customization and removal
2 participants
@MonaAghili @shahryarjb