compare: check segments #392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes crash mentioned on minio#389
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a crash by ensuring that the nil check for the "Segmented" field is more comprehensive before accessing its "Segments" member.
- Added nil checks for both the "Segmented" field and its "Segments" member in both the "before" and "after" objects.
- Updates the condition in pkg/aggregate/compare.go to prevent potential crashes when "Segmented" is nil.
Comments suppressed due to low confidence (1)
pkg/aggregate/compare.go:35
- The error message accesses 'Segments' on 'before.Throughput.Segmented' and 'after.Throughput.Segmented' without checking if these fields are nil. This may lead to a nil pointer dereference when formatting the error message. Consider modifying the error message to safely handle nil 'Segmented' values without directly accessing their 'Segments' field.
return nil, fmt.Errorf("no segments found in benchmark run. before: %v, after %v", before.Throughput.Segmented.Segments, after.Throughput.Segmented.Segments)
harshavardhana
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes crash mentioned on #389