Skip to content

Fix wrong obj count when doing multiobject #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 11, 2025
Merged

Fix wrong obj count when doing multiobject #368

merged 2 commits into from
Feb 11, 2025

Conversation

klauspost
Copy link
Collaborator

Segments were counting operations and not objects.

Bumping version, but not bothering converting.

Bonus check for zeros when dividing.

before/after

λ go build&&warp analyze -analyze.op=list warp-list-2023-09-22[093724]-3GWn.csv.zst
16176 operations loaded... Done!

Report: LIST (6176 reqs). Ran Duration: 57s, starting 09:37:29 CEST
 * Objects per request: 100. Concurrency: 100. Hosts: 2.
 * Average: 10221.03 obj/s (57s)
 * Reqs: Avg: 981.9ms, 50%: 971.1ms, 90%: 1112.4ms, 99%: 1271.6ms, Fastest: 358.6ms, Slowest: 1545.5ms, StdDev: 103.9ms
 * TTFB: Avg: 982ms, Best: 358ms, 25th: 915ms, Median: 971ms, 75th: 1.041s, 90th: 1.112s, 99th: 1.272s, Worst: 1.545s StdDev: 104ms

Throughput by host:
 * http://127.0.0.1:9001: Avg: 5136.87 obj/s (60s)
 * http://127.0.0.1:9002: Avg: 5097.02 obj/s (60s)

Throughput, split into 57 x 1s:
 * Fastest: 111.12 obj/s (1s, starting 09:37:48 CEST)
 * 50% Median: 105.12 obj/s (1s, starting 09:38:19 CEST)
 * Slowest: 85.76 obj/s (1s, starting 09:37:35 CEST)
 
λ go build&&warp analyze -analyze.op=list warp-list-2023-09-22[093724]-3GWn.csv.zst
16176 operations loaded... Done!

Report: LIST (6176 reqs). Ran Duration: 57s, starting 09:37:29 CEST
 * Objects per request: 100. Concurrency: 100. Hosts: 2.
 * Average: 10221.03 obj/s (57s)
 * Reqs: Avg: 981.9ms, 50%: 971.1ms, 90%: 1112.4ms, 99%: 1271.6ms, Fastest: 358.6ms, Slowest: 1545.5ms, StdDev: 103.9ms
 * TTFB: Avg: 982ms, Best: 358ms, 25th: 915ms, Median: 971ms, 75th: 1.041s, 90th: 1.112s, 99th: 1.272s, Worst: 1.545s StdDev: 104ms

Throughput by host:
 * http://127.0.0.1:9001: Avg: 5136.87 obj/s (60s)
 * http://127.0.0.1:9002: Avg: 5097.02 obj/s (60s)

Throughput, split into 57 x 1s:
 * Fastest: 11112.47 obj/s (1s, starting 09:37:48 CEST)
 * 50% Median: 10511.65 obj/s (1s, starting 09:38:19 CEST)
 * Slowest: 8575.95 obj/s (1s, starting 09:37:35 CEST)

Yes, the last numbers are the correct ones.

@klauspost
Fix wrong obj count when doing multiobject
d35fda5 
Segments were counting operations and not objects.

Bumping version, but not bothering converting.

Bonus check for zeros when dividing.
@klauspost
Merge branch 'master' into fix-obj-count
b33bef2
@harshavardhana harshavardhana merged commit a102fcd into minio:master Feb 11, 2025
6 checks passed
@klauspost klauspost deleted the fix-obj-count branch February 11, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klauspost @harshavardhana