Skip to content

Fix(multipart-put): add parts on multipart complete #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

Warh40k
Copy link
Contributor

@Warh40k Warh40k commented Jun 19, 2025

When I tried to use multipart-put to test concurrent multipart uploads, I expected it to create multipart parts completely, just like warp-multipart.
However, the multipart-put benchmark always sends an empty CompleteMultipartUploadRequest XML to the storage, which leads to server errors:

<CompleteMultipartUpload xmlns=\"http://s3.amazonaws.com/doc/2006-03-01/\"></CompleteMultipartUpload>

For example, I receive an error when testing with MinIO:

<Error><Code>InvalidRequest</Code><Message>You must specify at least one part</Message>...

The issue occurs because multipart-put does not include part information in completeMultipartInfo, whereas the multipart benchmark does.

Steps to reproduce:

  1. Deploy default Minio (e.g. with Docker)
  2. run benchmark as follows and you will see many <warp: complete multipart upload> errors:
./warp multipart-put --host 127.0.0.1:9000 \
                      --access-key=minioadmin \
                      --secret-key=minioadmin \
                          --parts=10 --part.size=5MiB --part.concurrent=5 --concurrent=5 \
                          --duration=5s \
                          --bucket=testbucket

Signed-off-by: Warh40k <nicita.zinkevitch@yandex.ru>
@klauspost klauspost merged commit fc415c8 into minio:master Jun 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants