Fix(multipart-put): add parts on multipart complete #403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tried to use
multipart-put
to test concurrent multipart uploads, I expected it to create multipart parts completely, just likewarp-multipart
.However, the multipart-put benchmark always sends an empty
CompleteMultipartUploadRequest
XML to the storage, which leads to server errors:For example, I receive an error when testing with MinIO:
The issue occurs because multipart-put does not include part information in completeMultipartInfo, whereas the multipart benchmark does.
Steps to reproduce:
<warp: complete multipart upload>
errors: