Add constants for response errors #2120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Introduces named constants for common S3 error codes and updates the codebase to use them for consistency.
- Declares constants for standard AWS S3 error codes.
- Refactors
s3ErrorResponseMapand error-generation functions to use these constants. - Updates tests to replace raw string literals with the new constants.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| s3-error.go | Added error code constants and switched map keys to use those constants |
| api-error-response.go | Refactored HTTP-to-error mapping and helpers to reference constants and s3ErrorResponseMap |
| api-error-response_test.go | Updated test cases to use error code constants instead of literal strings |
Comments suppressed due to low confidence (3)
api-error-response.go:221
- No test covers
errTransferAccelerationBucket; consider adding a unit test to validate this error scenario.
func errTransferAccelerationBucket(bucketName string) error {
api-error-response.go:279
- No test covers the
errAPINotSupportedhelper; consider adding tests to ensure its behavior and message are correct.
func errAPINotSupported(message string) error {
api-error-response.go:212
- The region-mismatch branch isn't covered by existing tests; add a test to verify the formatted region mismatch message.
if errResp.Code == InvalidRegion && errResp.Region != "" {
|
Would it be much work to add the rest? Seems a bit random which are added and which are not. |
b787d12 to
822cbbd
Compare
I guess no, I will be add them soon. |
klauspost
reviewed
Jun 5, 2025
5756273 to
241e2a1
Compare
Added dot for error sentence Added dots for errors messages Review all error codes add minio constants in functional_tests Fix error message in functional tests move static err messages to constants
harshavardhana
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.