Add support of error responses in 200 OK body #2115
Conversation
5323b55 to
5a11e3a
Compare
An S3 server can respond with 200 OK with an S3 Error response, for long standing calls, such as S3 listing when a prefix contains a lot of entries. This commit will support this use case. This can only be enabled with specific calls, that returns XML as a success response, so this will not be confused with GetObject returning a valid document that contains an S3 error response. Supported calls: CompleteMultipartUpload and DeleteMultiObjects.
|
@harshavardhana I wrote those tests. I also added more fixes to the original code to make those tests passing. minio-go was not retrying SlowDownRead and SlowDownWrite, it is only recognizing SlowDown error code. |
ah we forgot to change support for differentiation here, even AWS SDKs might not retry, perhaps we should change it back and add another field to the error type? |
Talking about server side. |
|
can you fix the build @vadmeste ? |
Co-authored-by: Harshavardhana <harsha@minio.io>
An S3 server can respond with 200 OK with an S3 Error response, for long standing calls,
such as S3 listing when a prefix contains a lot of entries.
This commit will support this use case. This can only be enabled with specific calls,
that returns XML as a success response, so this will not be confused with GetObject
returning a valid document that contains an S3 error response.
Supported calls: CompleteMultipartUpload and DeleteMultiObjects.