Add msgpack serializers to stringset #2107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add binary (de)serializers using msgp to stringsets. Should we move this to to `minio/pkg` instead?
There was a problem hiding this comment.
Pull Request Overview
This PR adds msgpack-based serialization and deserialization support for StringSet.
- Implements a new method, ToByteSlices, in pkg/set/stringset.go to convert the set to a sorted slice of byte slices.
- Introduces pkg/set/msgp.go with msgp encode, decode, marshal, and unmarshal functions for StringSet.
- Updates go.mod to include required dependencies for msgp and supplemental libraries.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/set/stringset.go | Adds ToByteSlices method and preallocates maps for set creation. |
| pkg/set/msgp.go | Implements msgpack serialization functions for StringSet. |
| go.mod | Adds dependencies for msgp and fwd. |
harshavardhana
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add binary (de)serializers using msgp to stringsets.
Should we move this to to
minio/pkginstead?