Add header for lifecycle config expiry to ignore replication #1999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadmeste
reviewed
Sep 13, 2024
this setting is for ILM to expire unreplicated versions or not - it belongs here |
harshavardhana
requested changes
Sep 17, 2024
klauspost
reviewed
Sep 17, 2024
ef88c47 to
c5af76b
Compare
| @@ -127,4 +127,7 @@ const ( | |||
| minioTgtReplicationReady = "X-Minio-Replication-Ready" | |||
| // Header asks if delete marker replication request can be sent by source now. | |||
| isMinioTgtReplicationReady = "X-Minio-Check-Replication-Ready" | |||
|
|
|||
| // Header indicating if ilm expiry ignores replication status | |||
There was a problem hiding this comment.
Header indicates if ILM expiration must trigger after replication
harshavardhana
approved these changes
Sep 19, 2024
|
PTAL @vadmeste @krisis @klauspost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.