fix: Send correct host header when an endpoint is IPv4 #1835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when the specified endpoint is an IP v4 address and the port is 80/443, minio-go sends a Host header with a bracket, which is wrong. An ipV4 can be converted to ip6 in golang library, therefore using ip.To4() shoud return nil if the passed IP is v6.
harshavardhana
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when the specified endpoint is an IP v4 address and the port is 80/443,
minio-go sends a Host header with a bracket, which is wrong.
An ipV4 can be converted to ip6 in golang library, therefore using ip.To4() shoud
return nil if the passed IP is v6.