GetBucketLocation: Use vhost signature in case of v2 signature #1810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code always picks a path style signature when v2 mode is selected. Reviewing the history shows little information why it is done that way. A previous recent commit, 24cdd7f, though it seems correct, broke existing deployments that use GCS (e.g. minio/mc#4547) We should not sign v2 with path style when the endpoint is vhost. This commit is tested with MinIO/AWS/GCS when v2 is enabled.
harshavardhana
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code always picks a path style signature when
v2 mode is selected. Reviewing the history shows little information
why it is done that way.
A previous recent commit, 24cdd7f,
though it seems correct, broke existing deployments that use GCS
(e.g. minio/mc#4547)
We should not sign v2 with path style when the endpoint is vhost.
This commit is tested with MinIO/AWS/GCS when v2 is enabled.