Detect S3 region from OVH Cloud endpoints #1783
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As I mentioned this behavior is only meant for Amazon S3, OVH cloud is an alternative to AWS S3. We don't plan to have first class support here all clouds today and future. I will bring in a change where you can provide your own regex for region lookup during MinIO constructor initialization so that we don't pollute this SDK further. |
harshavardhana
added a commit
to harshavardhana/minio-go
that referenced
this pull request
Mar 4, 2023
harshavardhana
added a commit
that referenced
this pull request
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in #1782, a generic solution is not acceptable.
here is the regex that match all OVH CLOUD S3 endpoints.
Working at ovh in the public storage team, I can assure the endpoints matches
s3.region(.sub)?.cloud.ovh.(net|us). Futur endpoints will follow the same pattern.