fix: empty fileName cause Reader nil for PostPolicyBucketHandler #21323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: empty fileName cause Reader nil for PostPolicyBucketHandler
There was a problem hiding this comment.
Pull Request Overview
Fix the case where an empty fileName in the form causes reader to remain nil, resulting in a nil-pointer error in PostPolicyBucketHandler.
- Added a
nilcheck forreaderto return a clear malformed-request error - Preserved existing error-wrapping style for missing form fields
Comments suppressed due to low confidence (1)
cmd/bucket-handlers.go:1093
- Add a unit test covering the scenario where the form has no file (i.e.
reader == nil) to ensure this error path is exercised.
if reader == nil {
harshavardhana
approved these changes
May 27, 2025
klauspost
approved these changes
May 27, 2025
harshavardhana
pushed a commit
that referenced
this pull request
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: empty fileName cause Reader nil for PostPolicyBucketHandler
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
We will got a nil Reader if the fileName is empty.
We ignore here:
minio/cmd/bucket-handlers.go
Lines 993 to 996 in 0f01cb0
fix #21319
Motivation and Context
How to test this PR?
Types of changes
Checklist:
commit-idorPR #here)