fix wrong time.Parse params order #19279
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
I write a linter to fix some bugs that occurred in my real work. --> https://github.com/alingse/sundrylint
in this case, it report the wrong params order for
time.Parse
, this should betime.Parse(layout, value)
and I run a github actions to check to most popular golang repos, here is minio failure
https://github.com/alingse/sundrylint/actions/runs/8309027408/job/22739917265
the linter output is
Motivation and Context
Fix the PR
How to test this PR?
I don't know how to write a test for this part
maybe should add some attribute check in TestAPICopyObjectHandler?
If someone give a case, I would like to add one
Types of changes
Checklist:
commit-id
orPR #
here)