Tweak multipart uploads #19756
Merged
Tweak multipart uploads #19756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Actually store modtime in upload id, return when listing instead of current time. * Use modtime for expiring and skip reading the file info. * Consistent upload sorting in listing (since it now actually has the modtime). * Try to exclude healing disks.
klauspost
added a commit
to klauspost/minio-go
that referenced
this pull request
May 16, 2024
Test listing of known multipart upload objects. Requires minio/minio#19756 which gives consistent upload sorting.
poornas
requested changes
May 16, 2024
vadmeste
reviewed
May 17, 2024
harshavardhana
approved these changes
May 17, 2024
poornas
approved these changes
May 17, 2024
harshavardhana
pushed a commit
to minio/minio-go
that referenced
this pull request
May 29, 2024
Test listing of known multipart upload objects. Requires minio/minio#19756 which gives consistent upload sorting.
harshavardhana
pushed a commit
that referenced
this pull request
Mar 17, 2025
* Store ModTime in the upload ID; return it when listing instead of the current time. * Use this ModTime to expire and skip reading the file info. * Consistent upload sorting in listing (since it now has the ModTime). * Exclude healing disks to avoid returning an empty list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix minor issues when reviewing ListMultipartUploads:
How to test this PR?
Sending a mint test to minio-go.
Types of changes