Skip to content

fix: no data transition will show error for when mc ilm info not found #5177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Mar 28, 2025

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Before this pr, we just match the name to show info.
But here is sure that no data transition, can't get any infomation about the TIER-NAME

mc.exe mb minio9000/mytest
mc.exe mb minio9001/mytest
mc.exe ilm tier add minio minio9000 warm  --endpoint http://127.0.0.1:9001 --access-key minioadmin --secret-key minioadmin --bucket mytest --prefix warmer
mc.exe ilm add --transition-days 1 --transition-tier "WARM" minio9000/mytest
mc.exe ilm tier info minio9000 WARM
mc.exe cp issue.sh minio9000/mytest/warmer/issue.sh
mc.exe cp issue.sh minio9000/mytest/warmer/issue1.sh
mc.exe cp issue.sh minio9000/mytest/warmer/issue2.sh

output:

No remote tiers' name match WARM

Now will show this:

┌─────────┬─────┬────┬─────┬───────┬────────┐
│Tier Name│ API │Type│Usage│Objects│Versions│
├─────────┼─────┼────┼─────┼───────┼────────┤
│  WARM   │minio│warm│ 0 B │   0   │   0    │
└─────────┴─────┴────┴─────┴───────┴────────┘

Motivation and Context

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

fix: no data  transition will show error for ilm info not found
@jiuker jiuker changed the title fix: no data transition will show error for ilm info not found fix: no data transition will show error for when mc ilm info not found Mar 28, 2025
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please explain the need for the change a bit more in description of the PR

@harshavardhana harshavardhana merged commit 5ce725b into minio:master Mar 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants