Skip to content

fix: error out when the source and destination might be subdirectories of each other #5173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 2, 2025
Merged

fix: error out when the source and destination might be subdirectories of each other #5173

merged 6 commits into from
Apr 2, 2025

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Mar 25, 2025 •
edited
Loading

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

fix: error out when the source and destination might be subdirectories of each other
fix #5170

Motivation and Context

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@jiuker jiuker changed the title fix: error out source and target are the same for mv fix: error out when source and target are the same for mv Mar 25, 2025
shtripat
shtripat reviewed Mar 25, 2025
View reviewed changes
@jiuker jiuker requested a review from shtripat March 26, 2025 02:27
@jiuker jiuker changed the title fix: error out when source and target are the same for mv fix: error out when the source and destination might be subdirectories of each other Mar 26, 2025
@jiuker jiuker force-pushed the fix-error-out-when-source-and-target-url-are-the-same-for-mv branch from ae24818 to abec01a Compare March 26, 2025 02:52
harshavardhana
harshavardhana requested changes Mar 26, 2025
View reviewed changes
Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check that you added fails for situations like

mc mv /tmp/file.tmp /tmp/file

@jiuker jiuker requested a review from harshavardhana March 26, 2025 07:15
@jiuker jiuker force-pushed the fix-error-out-when-source-and-target-url-are-the-same-for-mv branch 2 times, most recently from 422af5f to bc455da Compare March 26, 2025 07:46
@jiuker
Copy link
Contributor Author

jiuker commented Mar 28, 2025

@shtripat @harshavardhana Need this to fix linter.

@harshavardhana
Copy link
Member

@jiuker will send a separate PR for that from miniohq/ec

error out when the source and destination might be subdirectories of …
8c9cd37 
…each other

error out when the source and destination might be subdirectories of each other
@jiuker jiuker force-pushed the fix-error-out-when-source-and-target-url-are-the-same-for-mv branch from f0ecdde to 8c9cd37 Compare March 28, 2025 08:31
ramondeklein
ramondeklein requested changes Apr 1, 2025
View reviewed changes
ut
70e7d05 
ut
@jiuker jiuker requested a review from ramondeklein April 1, 2025 09:17
jiuker added 2 commits April 1, 2025 17:20
lint
e02300a 
lint
remove doc
ea4b159 
remove doc
klauspost
klauspost approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for being unclear in the error.

@jiuker @klauspost
Update cmd/mv-main.go
7e25b4b 
Co-authored-by: Klaus Post <klauspost@gmail.com>
shtripat
shtripat approved these changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harshavardhana harshavardhana merged commit 2d305ce into minio:master Apr 2, 2025
5 checks passed
dyakovri added a commit to mc-actions/publish that referenced this pull request Apr 13, 2025
@dyakovri
Temporary fix mv
fdcefdb 
mv dir to dir/subdir not not supported minio/mc#5173

todo: make a content backup durung uploading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@klauspost klauspost klauspost approved these changes

@shtripat shtripat shtripat approved these changes

@ramondeklein ramondeklein Awaiting requested review from ramondeklein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mc mv command on same bucket delete file
5 participants
@jiuker @harshavardhana @klauspost @ramondeklein @shtripat