Skip to content

pre-emptively disable sha256 payload if checksum is set #5167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

harshavardhana
Copy link
Member

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

pre-emptively disable sha256 payload if checksum is set

Motivation and Context

just making sure we do not compute sha256 payload
along with x-amz-checksum

How to test this PR?

Observe that mc put doesn't compute any sha256 payload
non TLS connections when --checksum is selected.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@harshavardhana harshavardhana requested a review from zveinn March 20, 2025 15:40
@harshavardhana harshavardhana merged commit d249b65 into minio:master Mar 27, 2025
5 checks passed
@harshavardhana harshavardhana deleted the disable-sha256-payload branch March 27, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants