Skip to content

Update madmin-go to latest version #5161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

Update madmin-go to latest version #5161

merged 1 commit into from
Mar 11, 2025

Conversation

anjalshireesh
Copy link
Contributor

@anjalshireesh anjalshireesh commented Mar 10, 2025 •
edited
Loading

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Update madmin-go to latest version and clear reference to the removed variable
madmin.HealthDataTypeSysLoad

How to test this PR?

mc support diag command should continue to work fine

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@anjalshireesh
Update madmin-go to latest version
4830a3e 
and clear reference to the removed variable madmin.HealthDataTypeSysLoad
shtripat
shtripat approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anjalshireesh anjalshireesh marked this pull request as ready for review March 10, 2025 10:52
@donatello donatello merged commit b3a00e0 into master Mar 11, 2025
5 checks passed
@donatello donatello deleted the madmin branch March 11, 2025 17:47
@harshavardhana
Copy link
Member

@anjalshireesh can you send these changes to miniohq/ec

@anjalshireesh
Copy link
Contributor Author

@anjalshireesh can you send these changes to miniohq/ec

@harshavardhana it's already covered in https://github.com/miniohq/ec/pull/41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donatello donatello donatello approved these changes

@shtripat shtripat shtripat approved these changes

@harshavardhana harshavardhana Awaiting requested review from harshavardhana

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anjalshireesh @harshavardhana @donatello @shtripat