Add admin accesskey sts-revoke and idp ldap accesskey sts-revoke
#5160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for STS token revocation by introducing two new commands for LDAP users and admin users.
- Adds the "sts-revoke" subcommand for idp ldap accesskeys via a new file (idp-ldap-accesskey-sts-revoke.go).
- Introduces the "sts-revoke" subcommand for admin accesskeys through a new file (admin-accesskey-sts-revoke.go) and updates auto-completion and command registration accordingly.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cmd/idp-ldap-accesskey.go | Registers the new sts-revoke subcommand |
| cmd/idp-ldap-accesskey-sts-revoke.go | Implements the STS token revocation command for LDAP |
| cmd/auto-complete.go | Updates auto-complete mappings for the new command |
| cmd/admin-accesskey.go | Registers the new sts-revoke subcommand for admin |
| cmd/admin-accesskey-sts-revoke.go | Implements the STS token revocation command for admin |
Files not reviewed (1)
- go.mod: Language not supported
Comments suppressed due to low confidence (2)
cmd/admin-accesskey-sts-revoke.go:102
- [nitpick] The comment refers to 'checkAdminUserSTSAcctInfoSyntax' while the function is named 'checkSTSRevokeSyntax'. Consider updating the comment to match the function's name.
// checkAdminUserSTSAcctInfoSyntax - validate all the passed arguments
cmd/admin-accesskey-sts-revoke.go:121
- [nitpick] The comment mentions 'mainAdminUserSTSAcctInfo', but the function is actually named 'mainAdminAccesskeySTSRevoke'. Please update the comment for consistency.
// mainAdminUserSTSAcctInfo is the handle for "mc admin accesskey sts-revoke" command.
harshavardhana
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
This PR adds
mc admin accesskey sts-revokeandmc idp ldap accesskey sts-revoke, two commands for STS token revocation. Theadmincommand can be used for builtin users or for self revocation by service accounts created for other user providers. Theidp ldapcommand can be used to revoke for LDAP users via short username or full DN.Motivation and Context
miniohq/eos#498
How to test this PR?
Create STS accounts and revoke them with this command.
Types of changes
Checklist:
commit-idorPR #here)