Skip to content

Add support for catalog batch job type #5150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

Add support for catalog batch job type #5150

merged 1 commit into from
May 2, 2025

Conversation

donatello
Copy link
Member

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

  • During batch yaml generation, we check if the server supports the kind of batch job requested.
  • Shows catalog job status

Motivation and Context

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@donatello donatello requested review from krisis and harshavardhana and removed request for krisis March 1, 2025 06:54
@donatello donatello force-pushed the catalog branch 3 times, most recently from 182f813 to 94d8458 Compare March 13, 2025 22:58
@harshavardhana
Copy link
Member

PTAL at the conflicts @donatello

@donatello
Copy link
Member Author

PTAL at the conflicts @donatello

Fixed PTAL

@donatello donatello force-pushed the catalog branch 2 times, most recently from 9042738 to 3fc7516 Compare April 2, 2025 23:37
@HJLebbink
Copy link
Member

Could you please add a line for the catalog jobtype here

mc/cmd/batch-generate.go

Line 45 in 56f94fd

- expire

@donatello
Copy link
Member Author

Could you please add a line for the catalog jobtype here

mc/cmd/batch-generate.go

Line 45 in 56f94fd

- expire

@HJLebbink Didn't add that because catalog is not supported on minio/minio - only in eos.

@donatello
Copy link
Member Author

PTAL @HJLebbink @shtripat @sivanantham-gnanavel

@shtripat
Copy link
Contributor

Could you please add a line for the catalog jobtype here

mc/cmd/batch-generate.go

Line 45 in 56f94fd

- expire

@HJLebbink Didn't add that because catalog is not supported on minio/minio - only in eos.

Is it like with eos upstream mc can be used for management. Also if there is no way to create catalog batch job using this mc, does this make sense to provide status option here?
Code changes as such look fine to me.

@harshavardhana
Copy link
Member

This PR must be only done to miniohq/ec not in this repo @donatello can you resubmit?

@donatello donatello reopened this Apr 23, 2025
@donatello
Add support for catalog batch job type
6d990f4 
- During batch yaml generation, we check if the server supports the kind
of batch job requested.
- Shows catalog job status
@harshavardhana harshavardhana merged commit 0a686cf into minio:master May 2, 2025
5 checks passed
@djwfyi djwfyi mentioned this pull request Jun 26, 2025
Open
3 tasks
dormanze added a commit to dormanze/mc that referenced this pull request Jul 14, 2025
@dormanze
Merge branch 'ping' of https://github.com/dormanze/mc into ping
b965a76 
* 'ping' of https://github.com/dormanze/mc: (44 commits)
  mv:support set tag and checksum (minio#5133)
  ping: support ping a specified node and remove duplicate port printing (minio#5132)
  feat: add `--storage-class` option to `mc put` subcommand (minio#5228)
  mirror and cp support set the maximum number of threads (minio#5220)
  Some paths like url2Stat will send resource with backslashes on windows (minio#5226)
  Include ARN in "replicate list" output (minio#5215)
  Update build version (minio#5218)
  fix: add checks for nil HTTP in admin-trace matches func (minio#5216)
  remove fips 'mc' container Dockerfile
  Fix deletion of previously sync'd buckets and objects during mc-mirror (minio#5205)
  Add STATUS column to batch job list table output (minio#5202)
  fix: remove check if lock config exists before set (minio#5203)
  removing config cmd (minio#5201)
  fix: support chained mirror properly for delete propagation minio#4558 (minio#5197)
  Change support profile defaults (minio#5198)
  Explicitly set file permissions for admin-cluster-{bucket,iam}-export… (minio#5194)
  Add support for catalog batch job type (minio#5150)
  Add `idp openid accesskey` commands (minio#5182)
  feat: add deletemarker info for batch status (minio#5191)
  mirror: skip status message from excluded buckets (minio#5190)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@krisis krisis Awaiting requested review from krisis

@HJLebbink HJLebbink Awaiting requested review from HJLebbink

@shtripat shtripat Awaiting requested review from shtripat

@sivanantham-gnanavel sivanantham-gnanavel Awaiting requested review from sivanantham-gnanavel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@donatello @harshavardhana @HJLebbink @shtripat